Fixed Slashcommand-Metrics missing subcommands#1434
Merged
Conversation
|
firasrg
approved these changes
Mar 11, 2026
Contributor
firasrg
left a comment
firasrg
left a comment
There was a problem hiding this comment.
Thank you for pointing this out. I wasn’t aware of subcommands, and this fix should take them into account i guess
marko-radosavljevic
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
metrics.count("slash-" + ...)code was forgetting about subcommands, such as/help-thread close. It only put the name of the slash command itself into the events, e.g./help-thread.This PR fixes the problem.